[OpenTelemetry] Refactor Lambda expressions #6852
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hoist condition out of lambda to only evaluate it once. - Simplify delegate declaration.
github-actions
bot
added
the
pkg:OpenTelemetry
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6852 +/- ##
==========================================
- Coverage 86.90% 86.89% -0.01%
==========================================
Files 263 263
Lines 12382 12381 -1
==========================================
- Hits 10761 10759 -2
- Misses 1621 1622 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Pull request overview
This PR refactors lambda expressions in the TracerProviderSdk for better performance and code clarity. The changes optimize conditional evaluation and simplify delegate declarations without altering the functional behavior.
Changes:
- Simplified lambda expression in
Any()method using method group conversion - Hoisted
supportLegacyActivitycondition check out of lambda to evaluate once at assignment time instead of on every invocation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)